Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update file extensions for Node TS support #6596

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update file extensions for Node TS support #6596

wants to merge 7 commits into from
+74 −4

Conversation

RDIL
Copy link
Member

@RDIL RDIL commented Nov 12, 2024 •
edited
Loading

What's the problem this PR addresses?

Fixes #6595

How did you fix it?

Always consider mts as ESM and cts as CJS

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@adrian-gierakowski
Copy link

Anything stopping progress on this PR?

@RDIL RDIL changed the title Treat .mts as an es module file Update file extensions for Node TS support Jan 20, 2025
@RDIL RDIL marked this pull request as ready for review January 20, 2025 15:34
@RDIL RDIL requested a review from merceyz January 20, 2025 15:34
@RDIL
Copy link
Member Author

RDIL commented Jan 20, 2025

Sorry @adrian-gierakowski, completely forgot to follow up here.

merceyz
merceyz requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@merceyz merceyz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs tests to ensure it works and that we don't regress on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merceyz merceyz merceyz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug?]: ERR_REQUIRE_ESM in Yarn PnP mode using Node.js 22 with *.mts file and --experimental-strip-types flag
3 participants
@RDIL @adrian-gierakowski @merceyz